Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Conversation

grexjmo
Copy link
Contributor

@grexjmo grexjmo commented Dec 19, 2019

Seems like a useful message config function to add

@nseidle
Copy link
Member

nseidle commented Dec 23, 2019

How did I get this far without a method for enabling/disabling various NMEA sentences? Jeesh! Thanks.

FYI - I may change the method name. We try to adhere to the Arduino Style Guide and avoid using _s where possible.

Also, in the future, please follow the contributing... Jeesh. I missing a contribution readme. I'll add that in the a bit, but in the future please add your new method(s) to the keywords.txt so it will get highlighted.

Thanks again! This helps a ton.

@nseidle nseidle merged commit f27def0 into sparkfun:master Dec 23, 2019
@grexjmo
Copy link
Contributor Author

grexjmo commented Dec 23, 2019

Will do. Honestly, my first ever github contribution, glad it worked. I'll pay better attention to the style guide if I submit anything else.

@nseidle
Copy link
Member

nseidle commented Dec 23, 2019

Cool! Congrats on your first contrib!

The plot thickens. Your PR configured the message for the interface being used (for example, your example does comm over I2C so the messages were only being enabled/disabled for the I2C port).

Neat. I can re-use the code from enableRTCMmessage() and make this better...

@grexjmo
Copy link
Contributor Author

grexjmo commented Dec 23, 2019

Yeah, I couldn't get it working correctly using the setVal8 command for specific ports ie : myGPS.setVal8(CFG_MSGOUT_NMEA_ID_GGA_I2C, 0)

Where I defined what I believe was the correct constants I needed:
const uint32_t CFG_MSGOUT_NMEA_ID_GGA_I2C = 0x209100ba;
const uint32_t CFG_MSGOUT_NMEA_ID_GLL_I2C = 0x209100c9;
const uint32_t CFG_MSGOUT_NMEA_ID_GNS_I2C = 0x209100b5;
const uint32_t CFG_MSGOUT_NMEA_ID_GRS_I2C = 0x209100ce;
const uint32_t CFG_MSGOUT_NMEA_ID_GSA_I2C = 0x209100bf;
const uint32_t CFG_MSGOUT_NMEA_ID_GST_I2C = 0x209100d3;
const uint32_t CFG_MSGOUT_NMEA_ID_GSV_I2C = 0x209100c4;
const uint32_t CFG_MSGOUT_NMEA_ID_RMC_I2C = 0x209100ab;
const uint32_t CFG_MSGOUT_NMEA_ID_VTG_I2C = 0x209100b0;
const uint32_t CFG_MSGOUT_NMEA_ID_ZDA_I2C = 0x209100d8;
const uint32_t CFG_MSGOUT_UBX_NAV_PVT_I2C = 0x20910006;

The F9P message configuration is bugged even via the latest ucenter version depending on how you try to set the rates. It works okay if you enable/disable by right clicking on the message type in the tree view of the messages window. But if I try changing message rates via the MSG tab in the configuration window, the entire GUI locks up on me pretty regularly.

Hence, I just added my command for configuring messages on the current port, since most of the library handles all of the GPS processing in the background anyway.

@nseidle
Copy link
Member

nseidle commented Dec 23, 2019

Ok, I just pushed a bunch of changes. I really liked your example so I pushed it up to position 6. Please let me know if I captured what you were trying to do (configure UART1 for just a few NMEA sentences).

image

@grexjmo
Copy link
Contributor Author

grexjmo commented Dec 23, 2019

Yessir. Just wanted a script to allow locally parsing GPS info while additionally forwarding complete NMEA strings out to a secondary device.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants